Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RichTextEditor): integrate Image plugin #3723

Merged
merged 13 commits into from
Jul 17, 2023
Merged

Conversation

TomasSlama
Copy link
Contributor

@TomasSlama TomasSlama commented Jul 14, 2023

FX-4172

Description

Collection of completed PRs:

How to test

  • Temploy
  • Final check of all parts in the storybook after rebasing

Screenshots

Before. After.
Insert screenshots or screen recordings Insert screenshots or screen recordings

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2023

🦋 Changeset detected

Latest commit: aa5537c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-rich-text-editor Major
@toptal/picasso-forms Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TomasSlama TomasSlama changed the title Fx 4172 feature branch feat(RichTextEditor): integrate Image plugin Jul 14, 2023
@toptal-devbot toptal-devbot temporarily deployed to temploy July 14, 2023 07:26 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 14, 2023 08:18 Inactive
@TomasSlama TomasSlama marked this pull request as ready for review July 14, 2023 09:03
@TomasSlama TomasSlama requested a review from a team as a code owner July 14, 2023 09:03
@toptal-devbot toptal-devbot temporarily deployed to temploy July 14, 2023 09:14 Inactive
@TomasSlama
Copy link
Contributor Author

@toptal-bot run package:alpha-release

1 similar comment
@TomasSlama
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal toptal deleted a comment from toptal-devbot Jul 17, 2023
@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@48.0.1-alpha-fx-4172-feature-branch-e9e40af5a.10+e9e40af5a
yarn add @toptal/[email protected]+e9e40af5a
yarn add @toptal/[email protected]+e9e40af5a
yarn add @toptal/[email protected]+e9e40af5a
yarn add @toptal/[email protected]+e9e40af5a
yarn add @toptal/picasso-pictograms@1.1.2-alpha-fx-4172-feature-branch-e9e40af5a.96+e9e40af5a
yarn add @toptal/[email protected]+e9e40af5a
yarn add @toptal/picasso-rich-text-editor@3.1.1-alpha-fx-4172-feature-branch-e9e40af5a.5+e9e40af5a
yarn add @toptal/[email protected]+e9e40af5a

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@48.0.1-alpha-fx-4172-feature-branch-6d3164d98.11+6d3164d98
yarn add @toptal/[email protected]+6d3164d98
yarn add @toptal/[email protected]+6d3164d98
yarn add @toptal/[email protected]+6d3164d98
yarn add @toptal/[email protected]+6d3164d98
yarn add @toptal/picasso-pictograms@1.1.2-alpha-fx-4172-feature-branch-6d3164d98.97+6d3164d98
yarn add @toptal/[email protected]+6d3164d98
yarn add @toptal/picasso-rich-text-editor@3.1.1-alpha-fx-4172-feature-branch-6d3164d98.6+6d3164d98
yarn add @toptal/[email protected]+6d3164d98

@toptal-devbot toptal-devbot temporarily deployed to temploy July 17, 2023 10:28 Inactive
@TomasSlama
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@48.0.1-alpha-fx-4172-feature-branch-b1d727401.12+b1d727401
yarn add @toptal/[email protected]+b1d727401
yarn add @toptal/[email protected]+b1d727401
yarn add @toptal/[email protected]+b1d727401
yarn add @toptal/[email protected]+b1d727401
yarn add @toptal/picasso-pictograms@1.1.2-alpha-fx-4172-feature-branch-b1d727401.98+b1d727401
yarn add @toptal/[email protected]+b1d727401
yarn add @toptal/picasso-rich-text-editor@3.1.1-alpha-fx-4172-feature-branch-b1d727401.7+b1d727401
yarn add @toptal/[email protected]+b1d727401

@toptal-devbot toptal-devbot temporarily deployed to temploy July 17, 2023 11:32 Inactive
Copy link
Member

@augustobmoura augustobmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of it was approved on the different PRs to the feature branch, GJ everyone! 👍

@toptal-devbot toptal-devbot temporarily deployed to temploy July 17, 2023 13:00 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 17, 2023 13:12 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 17, 2023 14:40 Inactive
@TomasSlama TomasSlama merged commit 11d8463 into master Jul 17, 2023
12 checks passed
@TomasSlama TomasSlama deleted the fx-4172-feature-branch branch July 17, 2023 14:41
@toptal-build toptal-build mentioned this pull request Jul 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants