Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [FX-4058] update jira deployments GH Action #3718

Merged
merged 12 commits into from
Jul 27, 2023

Conversation

dmaklygin
Copy link
Contributor

@dmaklygin dmaklygin commented Jul 11, 2023

FX-4058

Description

Describe the changes and motivations for the pull request.

How to test

  • the new JIRA deployment must be create in FX-4058 ticket

Development checks

  • Self reviewed

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

⚠️ No Changeset found

Latest commit: e5f6abf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dmaklygin dmaklygin self-assigned this Jul 11, 2023
@toptal-devbot toptal-devbot temporarily deployed to temploy July 11, 2023 21:52 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 11, 2023 22:48 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 11, 2023 22:58 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 11, 2023 23:10 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 00:09 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 08:17 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 08:31 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 09:01 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 09:21 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 13:35 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 13:56 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 14:30 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 14:44 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 15:13 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 15:48 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 16:29 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 12, 2023 17:06 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 13, 2023 17:40 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 13, 2023 17:48 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 13, 2023 18:00 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 13, 2023 18:36 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 25, 2023 17:00 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 25, 2023 17:11 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 25, 2023 17:24 Inactive
@dmaklygin
Copy link
Contributor Author

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy July 26, 2023 19:06 Inactive
Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not testing it as you said that you were testing it with Vedran 🙇

@toptal-devbot toptal-devbot temporarily deployed to staging July 27, 2023 07:27 Inactive
@dmaklygin dmaklygin merged commit 5087781 into master Jul 27, 2023
@dmaklygin dmaklygin deleted the test-jira-deployments branch July 27, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants