Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rich-text-editor): make emoji plugin a component #3708

Merged
merged 6 commits into from
Jul 14, 2023

Conversation

augustobmoura
Copy link
Member

@augustobmoura augustobmoura commented Jul 7, 2023

FX-4137

Description

The emoji plugin can now be used as a component plugin, old string plugin will still work

How to test

  • Check employ for emoji plugin

Screenshots

No screenshots

Development checks

Breaking change

  • [NA] codemod is created and showcased in the changeset
  • [NA] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@augustobmoura augustobmoura requested a review from a team as a code owner July 7, 2023 06:49
@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

🦋 Changeset detected

Latest commit: b6b0fc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-rich-text-editor Minor
@toptal/picasso Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal-devbot toptal-devbot temporarily deployed to temploy July 7, 2023 07:01 Inactive
@augustobmoura augustobmoura self-assigned this Jul 7, 2023
Copy link
Contributor

@dmaklygin dmaklygin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked. Works!

Copy link
Member

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left one small remark

* feat(rich-text-editor): move toolbar plugin groups to portal

* chore: add changeset

* feat: simplify toolbar portal
@toptal-devbot toptal-devbot temporarily deployed to temploy July 13, 2023 19:09 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy July 13, 2023 20:10 Inactive
@augustobmoura augustobmoura merged commit f3b2622 into master Jul 14, 2023
12 checks passed
@augustobmoura augustobmoura deleted the fx-4137-make-emoji-plugin-optional branch July 14, 2023 00:40
@toptal-build toptal-build mentioned this pull request Jul 14, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants