Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing icons and enforce icon sizes #3702

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Jul 5, 2023

FX-4158

Description

According to BASE design (https://www.figma.com/file/TqaGgbpjGSUDf7qq153Isq/Product-Iconography?type=design&node-id=1-2969&mode=design&t=Sz5fcUd1rnrqmlWx-0), icons should always have 16px and 24px versions (https://toptal-core.slack.com/archives/C05CSR5RFBN/p1688574324432869?thread_ts=1687249523.324339&cid=C05CSR5RFBN).

This pull request adds missing icons (taken from BASE) and adds a pre-commit check that makes sure that icon is added.

⚠️ Please note that Ach and CreditCard will be added after they are added to BASE

How to test

Screenshot 2023-07-05 at 20 04 03

Development checks

Breaking change

  • [N/A] codemod is created and showcased in the changeset
  • [N/A] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk added the no-jira label Jul 5, 2023
@sashuk sashuk self-assigned this Jul 5, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

🦋 Changeset detected

Latest commit: 82120e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@toptal/picasso Major
@toptal/picasso-charts Major
@toptal/picasso-forms Major
@toptal/picasso-rich-text-editor Major
@topkit/analytics-charts Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk force-pushed the FX-NULL-add-missing-icons branch 2 times, most recently from 9969e3b to 251e338 Compare July 5, 2023 18:05
@sashuk sashuk changed the title fix: add missing icons and enforce icon sizes feat: add missing icons and enforce icon sizes Jul 5, 2023
@sashuk sashuk force-pushed the FX-NULL-add-missing-icons branch from 251e338 to a1a83ce Compare July 5, 2023 18:08
@sashuk sashuk marked this pull request as ready for review July 5, 2023 18:10
@sashuk sashuk requested a review from a team as a code owner July 5, 2023 18:10
@sashuk
Copy link
Contributor Author

sashuk commented Jul 5, 2023

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy July 5, 2023 18:23 Inactive
@sashuk sashuk force-pushed the FX-NULL-add-missing-icons branch from a1a83ce to 430d572 Compare July 6, 2023 18:03
@sashuk
Copy link
Contributor Author

sashuk commented Jul 6, 2023

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy July 6, 2023 18:15 Inactive
@sashuk sashuk removed the no-jira label Jul 6, 2023
Copy link
Member

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the pre-commit hook rule! I have one idea on how to improve it, but it's not too critical (even though pretty nice to have).

bin/check-icon-sizes.js Outdated Show resolved Hide resolved
.husky/pre-commit Show resolved Hide resolved
@sashuk sashuk requested review from a team and removed request for a team July 10, 2023 09:53
@sashuk sashuk force-pushed the FX-NULL-add-missing-icons branch from 430d572 to df8fe28 Compare July 10, 2023 13:03
@toptal-devbot toptal-devbot temporarily deployed to temploy July 10, 2023 13:18 Inactive
@sashuk sashuk force-pushed the FX-NULL-add-missing-icons branch from df8fe28 to ef60ce4 Compare July 10, 2023 13:56
@sashuk
Copy link
Contributor Author

sashuk commented Jul 10, 2023

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy July 10, 2023 14:08 Inactive
@sashuk sashuk force-pushed the FX-NULL-add-missing-icons branch from ef60ce4 to 82120e8 Compare July 10, 2023 16:04
@toptal-devbot toptal-devbot temporarily deployed to temploy July 10, 2023 16:17 Inactive
@sashuk sashuk merged commit 7fe284d into master Jul 10, 2023
12 checks passed
@sashuk sashuk deleted the FX-NULL-add-missing-icons branch July 10, 2023 16:18
@toptal-build toptal-build mentioned this pull request Jul 10, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants