Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [FX-4053] create codemods for RTE #3657

Merged
merged 6 commits into from
Jun 28, 2023
Merged

feat: [FX-4053] create codemods for RTE #3657

merged 6 commits into from
Jun 28, 2023

Conversation

dmaklygin
Copy link
Contributor

@dmaklygin dmaklygin commented Jun 26, 2023 •
edited
Loading

FX-4053

Description

Create codemods for RTE migration to a separate package.

How to test

  • Use alpha version of @toptal/picasso-codemod

RUN

npx @toptal/[email protected]+8a53efa8c v36.0.0 --run-in-band

Checked in Staff Portal: https://github.com/toptal/staff-portal/pull/10570

Development checks

  • Add changeset according to guidelines (if needed)
  • Self reviewed
  • Covered with tests

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@dmaklygin dmaklygin self-assigned this Jun 26, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4975888

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@toptal/picasso-codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dmaklygin
Copy link
Contributor Author

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/[email protected]+8a53efa8c
yarn add @toptal/[email protected]+8a53efa8c
yarn add @toptal/[email protected]+8a53efa8c
yarn add @toptal/[email protected]+8a53efa8c
yarn add @toptal/[email protected]+8a53efa8c
yarn add @toptal/[email protected]+8a53efa8c
yarn add @toptal/[email protected]+8a53efa8c
yarn add @toptal/picasso-rich-text-editor@1.0.2-alpha-feat-rte-codemod-8a53efa8c.3+8a53efa8c
yarn add @toptal/[email protected]+8a53efa8c

@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 22:03 Inactive
@dmaklygin dmaklygin changed the base branch from master to fx-4053-create-separate-package-for-rte June 27, 2023 12:51
@dmaklygin dmaklygin marked this pull request as ready for review June 27, 2023 13:28
@dmaklygin dmaklygin requested a review from a team as a code owner June 27, 2023 13:28
@dmaklygin
Copy link
Contributor Author

@toptal-anvil ping reviewers

1 similar comment
@dmaklygin
Copy link
Contributor Author

@toptal-anvil ping reviewers

dmaklygin
dmaklygin commented Jun 28, 2023
View reviewed changes
packages/picasso-codemod/bin/cli.mjs
@@ -28,7 +28,7 @@ const findFilesInMonorepo = () =>
execaSync('find', [
'.',
'-name',
'*.tsx',
'*.ts*',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it used to take only TSX files

dmaklygin
dmaklygin commented Jun 28, 2023
View reviewed changes
packages/picasso-codemod/bin/cli.mjs
@@ -105,6 +106,7 @@ export const run = () => {

Options
--parser-config Add parser config
--run-in-band Run serially in the current process (default: false)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to execute this codemod sequentially

OleksandrNechai
OleksandrNechai approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@OleksandrNechai OleksandrNechai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

packages/picasso-codemod/src/v36.0.0/__testfixtures__/imports.output.tsx Show resolved Hide resolved
packages/picasso-codemod/src/v36.0.0/__testfixtures__/imports.output.tsx Show resolved Hide resolved
packages/picasso-codemod/src/v36.0.0/rich-text-editor-replacement.ts Show resolved Hide resolved
@dmaklygin dmaklygin merged commit 93dbd1d into fx-4053-create-separate-package-for-rte Jun 28, 2023
@dmaklygin dmaklygin deleted the feat/rte-codemod branch June 28, 2023 13:15
dmaklygin added a commit that referenced this pull request Jun 28, 2023
@dmaklygin
feat: [FX-4053] create codemods for RTE (#3657)
8b24606 
* chore: create codemods for rte

* chore: adjust codemod

* chore: update eslint rules for codemod

* chore: update eslintignore

* chore: update prettier ignore

* chore: update version
dmaklygin added a commit that referenced this pull request Jun 28, 2023
@dmaklygin
feat: [FX-4053] move rich text editor to a separate package (#3637)
d4795a8 
* feat: move rich text editor to a separate package

* chore: rebase master branch

* chore: fix tests

* feat: [FX-4053] create codemods for RTE (#3657)

* chore: create codemods for rte

* chore: adjust codemod

* chore: update eslint rules for codemod

* chore: update eslintignore

* chore: update prettier ignore

* chore: update version

* chore: update the changeset

* chore: update changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OleksandrNechai OleksandrNechai OleksandrNechai approved these changes

@TomasSlama TomasSlama TomasSlama approved these changes

Assignees

@dmaklygin dmaklygin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmaklygin @toptal-devbot @TomasSlama @OleksandrNechai