Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [FX-4053] move rich text editor to a separate package #3652

Merged
merged 7 commits into from
Jun 26, 2023
Merged

feat: [FX-4053] move rich text editor to a separate package #3652

merged 7 commits into from
Jun 26, 2023

Conversation

dmaklygin
Copy link
Contributor

@dmaklygin dmaklygin commented Jun 26, 2023 •
edited
Loading

FX-4053

Description

We should create a new package @toptal/picasso-rich-text-editor.

How to test

  • Use temploy to check workability

Development checks

  • Add changeset according to guidelines (if needed)
  • Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Self reviewed
  • Covered with tests

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@dmaklygin dmaklygin self-assigned this Jun 26, 2023
@dmaklygin dmaklygin requested a review from a team as a code owner June 26, 2023 09:21
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d1b154e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso Patch
@toptal/picasso-rich-text-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 09:34 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 10:19 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 10:33 Inactive
@dmaklygin
Copy link
Contributor Author

@toptal-anvil ping reviewers

@dmaklygin dmaklygin force-pushed the fx-4053-create-rich-text-editor-package branch from d55767b to d58df7a Compare June 26, 2023 10:53
@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 11:06 Inactive
TomasSlama
TomasSlama approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in the temploy, looks good

augustobmoura
augustobmoura approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@augustobmoura augustobmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some small comments, but because we are only moving code around it should work regardless

.storybook/main.js Show resolved Hide resolved
packages/picasso-rich-text-editor/README.md Outdated Show resolved Hide resolved
packages/picasso-rich-text-editor/package.json Outdated Show resolved Hide resolved
@toptal-devbot toptal-devbot temporarily deployed to temploy June 26, 2023 15:13 Inactive
@dmaklygin dmaklygin merged commit 6b3b411 into master Jun 26, 2023
12 checks passed
@dmaklygin dmaklygin deleted the fx-4053-create-rich-text-editor-package branch June 26, 2023 15:17
@toptal-build toptal-build mentioned this pull request Jun 26, 2023
Merged
1 task
sashuk pushed a commit that referenced this pull request Jun 27, 2023
@dmaklygin @sashuk
feat: [FX-4053] move rich text editor to a separate package (#3652)
482b534 
* feat: move rich text editor to a separate package

* chore: update yarn.lock

* chore: get back picasso RTE

* chore: update pathnames

* chore: revert back cypress tests

* chore: fix

* chore: add readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustobmoura augustobmoura augustobmoura approved these changes

@TomasSlama TomasSlama TomasSlama approved these changes

Assignees

@dmaklygin dmaklygin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmaklygin @augustobmoura @TomasSlama @toptal-devbot