feat(OverviewBlock): add custom label #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1f142fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Greetings from FX team, @mateusbzerra 👋 Thank you so much for contributing 🙇 We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme! What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉 🙏 please, help us improve, rate your contributing experience after merge |
TomasSlama
reviewed
Jun 26, 2023
dmaklygin
reviewed
Jun 26, 2023
|
@toptal-anvil ping reviewers |
TomasSlama
approved these changes
Jun 26, 2023
mateusbzerra
force-pushed
the
sde-1114-add-overview-block-custom-label
branch
from
8799331
to
8bcf9fe
Compare
AnastasiiaLopushanska
approved these changes
Jun 27, 2023
dmaklygin
approved these changes
Jun 27, 2023
mateusbzerra
force-pushed
the
sde-1114-add-overview-block-custom-label
branch
from
8bcf9fe
to
1f142fd
Compare
sashuk
pushed a commit
that referenced
this pull request
Jun 27, 2023
* feat(OverviewBlock): add custom label * chore: add changeset * test(OverviewBlock): wrap test with a describe function * chore: update changeset message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDE-1114
Description
It implements a custom label to the OverviewBlock component, as requested here #3640
How to test
Screenshots
Development checks
propsin component with documentationexamplesfor componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release- Release alpha version@toptal-anvil ping reviewers- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?