[CPT-1478] Address review

toptal · Jan 4, 2024 · dc35eb9 · dc35eb9
1 parent 4f41aef
commit dc35eb9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 10 deletions.
diff --git a/.changeset/great-pens-do.md b/.changeset/great-pens-do.md
diff --git a/.changeset/rare-jokes-build.md b/.changeset/rare-jokes-build.md
@@ -0,0 +1,6 @@
+---
+'@toptal/picasso-query-builder': minor
+'@toptal/picasso': minor
+---
+
+- add `enableResetSearch` prop to `Select` component and provide it to `QueryBuilder` `Multiselect` field
diff --git a/packages/picasso-query-builder/src/MultiSelect/MultiSelect.tsx b/packages/picasso-query-builder/src/MultiSelect/MultiSelect.tsx
@@ -12,7 +12,6 @@ import styles from './styles'
 type Props = BaseVersatileSelectorProps &
   ValueEditorValidationProps & {
     valueEditorTestId?: string
-    enableResetSearch?: boolean
   }
 
 const useStyles = makeStyles(styles)
@@ -28,7 +27,6 @@ export const MultiSelect = ({
   className,
   fieldData,
   valueEditorTestId,
-  enableResetSearch,
 }: Props) => {
   const classes = useStyles()
 
@@ -59,7 +57,7 @@ export const MultiSelect = ({
         value={values}
         status={hasError ? 'error' : undefined}
         data-testid={valueEditorTestId}
-        enableResetSearch={enableResetSearch}
+        enableResetSearch={fieldData?.enableResetSearch}
       />
     </Container>
   )

diff --git a/packages/picasso-query-builder/src/ValueEditor/ValueEditor.tsx b/packages/picasso-query-builder/src/ValueEditor/ValueEditor.tsx
@@ -65,7 +65,6 @@ export const ValueEditor = ({
           touched={touched}
           fieldData={fieldData}
           valueEditorTestId={valueEditorTestId}
-          enableResetSearch={fieldData.enableResetSearch}
         />
       )
     case 'select':