[FX-5973] Update tag to span (#4567)

toptal · Sep 20, 2024 · 5287366 · 5287366
1 parent d5027ed
commit 5287366
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/eighty-eagles-warn.md b/.changeset/eighty-eagles-warn.md
@@ -0,0 +1,6 @@
+---
+'@toptal/picasso-tag': patch
+'@toptal/picasso': patch
+---
+
+- update HTML tag of Tag.Rectangular to span
diff --git a/packages/base/Tag/src/TagRectangular/TagRectangular.tsx b/packages/base/Tag/src/TagRectangular/TagRectangular.tsx
@@ -48,6 +48,7 @@ export const TagRectangular = forwardRef<HTMLDivElement, Props>(
             variant === 'light-grey' ? 'text-graphite-800' : 'text-white'
           )}
           titleCase={titleCase}
+          as='span'
         >
           {children}
         </Typography>

diff --git a/packages/base/Tag/src/TagRectangular/__snapshots__/test.tsx.snap b/packages/base/Tag/src/TagRectangular/__snapshots__/test.tsx.snap
@@ -8,11 +8,11 @@ exports[`TagRectangular renders rectangular Tag 1`] = `
     <div
       class="text-lg transition-none rounded-sm font-semibold h-4 inline-flex content-center justify-center align-middle bg-gray"
     >
-      <p
+      <span
         class="m-0 text-2xs font-semibold whitespace-nowrap overflow-ellipsis overflow-hidden mx-1 w-max text-graphite"
       >
         Reactangular Tag
-      </p>
+      </span>
     </div>
   </div>
 </div>