Address review comments

toptal · Sep 27, 2024 · 07c7cbf · 07c7cbf
1 parent 954e169
commit 07c7cbf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/packages/base/Page/src/PageHamburger/PageHamburger.tsx b/packages/base/Page/src/PageHamburger/PageHamburger.tsx
@@ -2,7 +2,6 @@ import React, { useState } from 'react'
 import { ButtonCircular } from '@toptal/picasso-button'
 import { Dropdown } from '@toptal/picasso-dropdown'
 import { Close24, Overview24 } from '@toptal/picasso-icons'
-import { twJoin } from '@toptal/picasso-tailwind-merge'
 
 import { useHamburgerContext } from './PageHamburgerContext'
 
@@ -21,7 +20,7 @@ const PageHamburger = ({ id, 'data-testid': dataTestId }: Props) => {
   return (
     <Dropdown
       content={<div id={id} ref={hamburgerRef} />}
-      className={twJoin('min-[1280px]:hidden', !showSidebarMenu && 'hidden')}
+      className={!showSidebarMenu ? 'hidden' : 'min-[1280px]:hidden'}
       classes={{
         content: `!shadow-[inset_-1px_0px_0px_0px] !shadow-gray-200 max-h-[calc(100vh-var(--header-height,3.5rem))] !bg-gray-100`,
         popper: 'mt-4',

diff --git a/packages/base/Page/src/PageTopBar/__snapshots__/test.tsx.snap b/packages/base/Page/src/PageTopBar/__snapshots__/test.tsx.snap
@@ -21,7 +21,7 @@ exports[`Page.TopBar render with custom logo 1`] = `
               class="gap-4 items-center flex"
             >
               <div
-                class="items-center min-[1280px]:hidden hidden"
+                class="items-center hidden"
               >
                 <div
                   class="inline-flex items-center cursor-pointer"
@@ -120,7 +120,7 @@ exports[`Page.TopBar render with link 1`] = `
               class="gap-4 items-center flex"
             >
               <div
-                class="items-center min-[1280px]:hidden hidden"
+                class="items-center hidden"
               >
                 <div
                   class="inline-flex items-center cursor-pointer"
@@ -245,7 +245,7 @@ exports[`Page.TopBar renders 1`] = `
               class="gap-4 items-center flex"
             >
               <div
-                class="items-center min-[1280px]:hidden hidden"
+                class="items-center hidden"
               >
                 <div
                   class="inline-flex items-center cursor-pointer"