Add node-version parameters #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4fb4230 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@toptal-anvil ping reviewers |
dmaklygin
reviewed
Nov 20, 2023
dmaklygin
approved these changes
Nov 20, 2023
augustobmoura
approved these changes
Nov 20, 2023
sashuk
deleted the
fx-4432-extend-davinci-gh-actions-to-support-custom-node-version
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-4432
Description
This pull request makes it possible to specify the version of Node.js used for 4 actions (that use the
actions/setup-nodeinside).How to test
As an example, the https://github.com/toptal/davinci-github-actions/tree/master/build-push-image action is tested in Picasso repo in toptal/picasso#3994
Development checks
PR commands
List of available commands:
@toptal-anvil ping reviewers- Ping FX team for review