Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hook: Allow tag:/[tag]/{tag} prefixes in subject #37

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ahmubashshir
Copy link

@ahmubashshir ahmubashshir commented Aug 3, 2021

This hook didn't detect cap'd subject when prefixed with tag:/[tag]/{tag}
eg.

tag(scope): Subject cap check failed
[tag] Subject cap check failed
{tag} Subject cap check failed

@(+([[:alnum:]])?(\(+([[:alnum:]])\)):|\[+([[:alnum:][:punct:]])\]|\{+([[:alnum:][:punct:]])\}|squash\!)
matches the prefixes and removes it from subject line before checking.

@ahmubashshir ahmubashshir force-pushed the allow-prefixes-in-subject branch 2 times, most recently from f5ee215 to 9ca300b Compare August 3, 2021 08:44
@ahmubashshir ahmubashshir changed the title hook: Detect caps in :/[]/{} prefixed subject hook: Allow tag:/[tag]/{tag} prefixes in subject Aug 3, 2021
@ahmubashshir ahmubashshir force-pushed the allow-prefixes-in-subject branch from da282bf to e365a99 Compare May 15, 2023 12:01
This hook didn't detect cap'd subject when prefixed with
tag:/[tag]/{tag} eg.

tag(scope): Subject cap check failed
[tag] Subject cap check failed
{tag} Subject cap check failed

'@(+([[:alnum:]])?(\(+([[:alnum:]])\)):|\[+([[:alnum:][:punct:]])\]|\{+([[:alnum:][:punct:]])\}|squash\!)'
matches the prefixes and removes it from subject line before checking.
See-also: 9ca300b (hook: Allow tag:/[tag]/{tag} prefixes in subject)
@ahmubashshir ahmubashshir force-pushed the allow-prefixes-in-subject branch from e365a99 to b0c60d7 Compare May 15, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant