-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Vagrant with provision #2
base: master
Are you sure you want to change the base?
Conversation
try_files $uri $uri/ /index.php?q=$uri&$args; | ||
} | ||
|
||
location ~ \.php$ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this pattern could be more restrictive, there is only one dispatcher file that needs to be accessible by php-fpm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right :D copy paste, thx for eagle eyes
- hosts: all | ||
roles: | ||
- role: app | ||
become: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity: why the become
on role level? Most of the time I have mixed permission requirements per role for the different tasks, therefore always set this on a task level, blindly executing everything with root sounds a bit risky to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my way for it. Set it to the roles not global. But i think this could be cleaned up for this special box
|
||
- name: Uninstall apache packages. | ||
apt: | ||
name: httpd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since when is this called httpd in Debian/Ubuntu? sure this is not supposed to be apache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jipp, it could removed in this ubuntu version. Got problems with older boxes
name: httpd | ||
state: absent | ||
|
||
- name: start and enable nginx service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really needed? apt automatically starts the service normally or is this purely for the case that apache had previously blocked the port when nginx was installed? in that case, removing apache before nginx would suffice also without this additional step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its to get shure that nginx will be restarted when adding my configuration for it, after copy processes I restart it
name: npm | ||
state: present | ||
|
||
- name: install yarn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the recommended way of installing yarn right now? I thought their apt repo would be the better choice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jay :D its not the best way, i´ll have a look for it
@@ -0,0 +1,18 @@ | |||
--- | |||
- name: install node sources | |||
shell: curl -sL https://deb.nodesource.com/setup_8.x | sudo -E bash - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't bionic's default node version already 8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its better to set the Version because of further updates
|
||
php_ini: | ||
'date.timezone': "Europe/Berlin" | ||
'memory_limit': 2048M |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait what??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My defaults for projects ;) could remove it, if not needed
@@ -0,0 +1,3 @@ | |||
#!/usr/bin/env bash | |||
|
|||
apt-get -y install python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary? I thought python was installed by default in Debian and Ubuntu for ages, might be mistaken though.
Not a vagrant expert, might be stupid question: ansible is available automatically or is it executed by the host system and needs to be installed there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got problems with provisioning without this pre-installation
Update