Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tokio-tungstenite to 0.23 #2841

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Conversation

hatchan
Copy link
Contributor

@hatchan hatchan commented Jul 23, 2024

Motivation

The latest version of tokio-tungstenite updates both tungstenite and rustls.

Solution

Upgrade tokio-tungstenite to 0.23.

@hatchan

This comment was marked as outdated.

@hatchan

This comment was marked as outdated.

@jplatte
Copy link
Member

jplatte commented Jul 23, 2024

Only things that matter for users of the library should be mentioned in the changelog, this is not the case for clippy fixes usually (unless public API is changes in response to a clippy lint). Having those fixes as a separate PR would be nice though.

@hatchan
Copy link
Contributor Author

hatchan commented Jul 23, 2024

Only things that matter for users of the library should be mentioned in the changelog, this is not the case for clippy fixes usually (unless public API is changes in response to a clippy lint). Having those fixes as a separate PR would be nice though.

I can separate it in a different PR, but it should work now 🥳

@hatchan
Copy link
Contributor Author

hatchan commented Jul 23, 2024

Once #2843 is merged I will rebase this PR on main and mark this PR as ready for review.

@hatchan hatchan marked this pull request as ready for review July 24, 2024 07:59
@jplatte jplatte merged commit 6dfd003 into tokio-rs:main Aug 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants