Remove duplication in serving with and without graceful shutdown #2803
+2
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
force-pushed
the
jplatte/reduce-serve-duplication
branch
from
7047547
to
04b729e
Compare
mladedav
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
This is great.
I just wonder if this couldn't go one step further and merge the Serve and WithGracefulShutdown into a single generic type. As it stands now, Serve<M, S> is just WithGracefulShutdown<M, S, Pending>` so why not embrace it?
The only difference I know of is that with the current separation users cannot call with_graceful_shutdown multiple times but I don't think that would be a problem.
|
Sure, could do that. But it feels like leaking implementation details into the public API, and I don't see the little bit of extra code as much of a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler implementation of the same idea from #2478, against latest
main.Closes #2478.