fix: keyboard controller should attach event on document #8801
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 183652e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
size-limit report 📦
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| private _listenKeyboard( | ||
| event: 'keydown' | 'keyup', | ||
| callback: (keyboardEvt: KeyboardEvent) => void | ||
| ) { | ||
| document.addEventListener(event, callback, false); | ||
|
|
||
| return () => { | ||
| document.removeEventListener(event, callback, false); | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
Does listening on the document affect user interactions on the AFFiNE side?
There was a problem hiding this comment.
I'm not sure. It should be fine.
There was a problem hiding this comment.
Have you tested the situation where multiple editors exist at the same time?
No description provided.