Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blocks): remove trigger key '、' from slash menu #8768

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Nov 20, 2024

Close BS-1757, related to #8662

This PR removes the trigger key from the slash menu to improve the CJK user input experience. For users of Sougo Pinyin on macOS, you can disable the auto-transform from / to in the IME settings.

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 5:42am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 5:42am

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: bfb0c7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Nov 20, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

L-Sun commented Nov 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bfb0c7f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

size-limit report 📦

Path Size
@blocksuite/affine 13 B (0%)
@blocksuite/affine/effects 2.08 MB (-0.01% 🔽)
@blocksuite/affine/block-std 156.64 KB (0%)
@blocksuite/affine/block-std/gfx 80.42 KB (0%)
@blocksuite/affine/global 13 B (0%)
@blocksuite/affine/global/utils 13.87 KB (0%)
@blocksuite/affine/global/env 217 B (0%)
@blocksuite/affine/global/exceptions 562 B (0%)
@blocksuite/affine/global/di 1.65 KB (0%)
@blocksuite/affine/global/types 13 B (0%)
@blocksuite/affine/store 78.78 KB (0%)
@blocksuite/affine/inline 32.09 KB (0%)
@blocksuite/affine/inline/consts 51 B (0%)
@blocksuite/affine/inline/types 13 B (0%)
@blocksuite/affine/presets 1.88 MB (-0.03% 🔽)
@blocksuite/affine/blocks 1.96 MB (-0.03% 🔽)
@blocksuite/affine/blocks/schemas 89.25 KB (0%)

@L-Sun L-Sun marked this pull request as ready for review November 20, 2024 04:47
@L-Sun L-Sun requested a review from a team as a code owner November 20, 2024 04:47
@L-Sun L-Sun added the merge label Nov 20, 2024
Copy link
Contributor Author

L-Sun commented Nov 20, 2024

Merge activity

  • Nov 20, 12:40 AM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 20, 12:40 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 20, 12:46 AM EST: A user merged this pull request with the Graphite merge queue.

Close [BS-1757](https://linear.app/affine-design/issue/BS-1757/中文输入法下触发slashmenu问题)

This PR removes the trigger key `、` from the slash menu to improve the CJK user input experience. For users of Sougo Pinyin on macOS, you can disable the auto-transform from `/` to `、` in the IME settings.
@L-Sun L-Sun force-pushed the l-sun/chore/adjust-trigger-key-of-slash-menu branch from 1b60ea8 to bfb0c7f Compare November 20, 2024 05:41
@graphite-app graphite-app bot merged commit bfb0c7f into master Nov 20, 2024
36 checks passed
@graphite-app graphite-app bot deleted the l-sun/chore/adjust-trigger-key-of-slash-menu branch November 20, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants