Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): impl doc display meta extension #9165

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Dec 16, 2024

Closes: BS-2111
Upstreams: toeverything/blocksuite#8953

Screen.Recording.2024-12-16.at.18.35.28.mov

Copy link
Contributor Author

fundon commented Dec 16, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon force-pushed the fundon/12_15_impl_doc_display_meta_extension branch 2 times, most recently from f279405 to 4111088 Compare December 16, 2024 01:36
@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:env mod:component app:electron Related to electron app mod:dev labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.76%. Comparing base (cbb52c6) to head (8f7f85d).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9165      +/-   ##
==========================================
+ Coverage   65.72%   65.76%   +0.04%     
==========================================
  Files         727      727              
  Lines       41418    41418              
  Branches     4097     4097              
==========================================
+ Hits        27221    27239      +18     
+ Misses      13761    13743      -18     
  Partials      436      436              
Flag Coverage Δ
server-test 78.26% <ø> (+0.06%) ⬆️
unittest 35.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fundon fundon force-pushed the fundon/12_15_impl_doc_display_meta_extension branch 2 times, most recently from 5129461 to 71f0de1 Compare December 16, 2024 03:02
@fundon fundon force-pushed the fundon/12_15_impl_doc_display_meta_extension branch 5 times, most recently from ad654f2 to 2e36000 Compare December 16, 2024 08:30
@fundon fundon marked this pull request as ready for review December 16, 2024 10:28
@graphite-app graphite-app bot requested review from forehalo, CatsJuice, EYHN, JimmFly and pengx17 and removed request for forehalo December 16, 2024 10:28
@fundon fundon force-pushed the fundon/12_15_impl_doc_display_meta_extension branch from 2e36000 to 092033e Compare December 17, 2024 02:37
@fundon fundon force-pushed the fundon/12_15_impl_doc_display_meta_extension branch 2 times, most recently from 3b94f10 to 689c9ed Compare December 18, 2024 00:57
@fundon fundon force-pushed the fundon/12_15_impl_doc_display_meta_extension branch from 689c9ed to 8f7f85d Compare December 18, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app app:server mod:component mod:dev mod:env mod:infra Environment related issues and discussions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants