Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add app version to request header #9101

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Dec 11, 2024

No description provided.

Copy link

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Dec 11, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added mod:infra Environment related issues and discussions app:core labels Dec 11, 2024
@JimmFly JimmFly marked this pull request as ready for review December 11, 2024 07:14
@JimmFly JimmFly changed the title feat(core): add minimum version check feat(core): init minimum version check Dec 11, 2024
@JimmFly JimmFly changed the title feat(core): init minimum version check feat(core): add app version to request header Dec 11, 2024
@JimmFly JimmFly force-pushed the jimmfly/1211/minimum-version branch from 6df1166 to 1cfa7b1 Compare December 11, 2024 07:16
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.76%. Comparing base (e13f9d3) to head (56dbfb2).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #9101   +/-   ##
=======================================
  Coverage   65.76%   65.76%           
=======================================
  Files         727      727           
  Lines       41420    41420           
  Branches     4098     4098           
=======================================
  Hits        27239    27239           
  Misses      13745    13745           
  Partials      436      436           
Flag Coverage Δ
server-test 78.26% <ø> (ø)
unittest 35.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/1211/minimum-version branch from 1cfa7b1 to 4d8abc4 Compare December 11, 2024 08:24
@JimmFly JimmFly force-pushed the jimmfly/1211/minimum-version branch 2 times, most recently from 7a668c5 to 03bedbe Compare December 12, 2024 03:09
@JimmFly JimmFly changed the base branch from canary to darksky/team-mail-sender December 12, 2024 03:09
@github-actions github-actions bot added mod:i18n Related to i18n app:server test Related to test cases labels Dec 12, 2024
@darkskygit darkskygit force-pushed the darksky/team-mail-sender branch from 0b08ae6 to c517611 Compare December 12, 2024 03:11
@JimmFly JimmFly force-pushed the jimmfly/1211/minimum-version branch from 03bedbe to 706e648 Compare December 12, 2024 03:11
@JimmFly JimmFly changed the base branch from darksky/team-mail-sender to canary December 12, 2024 03:11
@JimmFly JimmFly force-pushed the jimmfly/1211/minimum-version branch from 706e648 to 56dbfb2 Compare December 18, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:server mod:i18n Related to i18n mod:infra Environment related issues and discussions test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants