feat(nbstore): add idb implementation #8809
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
forehalo
force-pushed
the
61/adapt-op
branch
from
b327d33
to
ad2c6b7
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
9c98c50
to
5615c5e
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
5615c5e
to
a94a9b5
Compare
forehalo
force-pushed
the
61/adapt-op
branch
from
ad2c6b7
to
f4ec560
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
a94a9b5
to
4c0bf17
Compare
forehalo
force-pushed
the
61/adapt-op
branch
from
f4ec560
to
bdfb811
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
4c0bf17
to
28db859
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c8d16ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 61/adapt-op #8809 +/- ##
===============================================
+ Coverage 70.25% 70.30% +0.05%
===============================================
Files 550 550
Lines 33980 33980
Branches 3052 3052
===============================================
+ Hits 23871 23889 +18
+ Misses 9737 9719 -18
Partials 372 372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
forehalo
force-pushed
the
61/adapt-op
branch
from
bdfb811
to
bf6c0ab
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
28db859
to
4dba527
Compare
forehalo
force-pushed
the
61/adapt-op
branch
from
bf6c0ab
to
83cf4e2
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
4dba527
to
39f9bb7
Compare
forehalo
force-pushed
the
61/adapt-op
branch
from
83cf4e2
to
e41df6c
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
39f9bb7
to
a7d33ee
Compare
forehalo
force-pushed
the
61/adapt-op
branch
from
e41df6c
to
fa1a679
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
a7d33ee
to
362054a
Compare
forehalo
force-pushed
the
61/adapt-op
branch
from
fa1a679
to
9f18aa4
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
362054a
to
3565131
Compare
forehalo
changed the title
forehalo
force-pushed
the
61/adapt-op
branch
from
9f18aa4
to
09eda41
Compare
forehalo
force-pushed
the
61/space-store-idb
branch
from
3565131
to
c8d16ec
Compare
| * @deprecated readonly | ||
| */ | ||
| export class IndexedDBV1BlobStorage extends BlobStorage<IndexedDBV1BlobStorageOptions> { | ||
| readonly connection = share(new BlobIDBConnection(this.spaceId)); |
There was a problem hiding this comment.
The constructor parameter this.spaceId does not match the interface definition IndexedDBV1BlobStorageOptions which expects a dbName property. Please update to use this.options.dbName instead.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
No description provided.