Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix English oddities in README.md #8622

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

dandv
Copy link

@dandv dandv commented Oct 28, 2024

No description provided.

Copy link

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the docs Improvements or additions to documentation label Oct 28, 2024
@graphite-app graphite-app bot requested a review from forehalo October 28, 2024 20:35
Copy link
Contributor

@HeJiachen-PM HeJiachen-PM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help on our English!

Copy link

nx-cloud bot commented Oct 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 645dcf4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.11%. Comparing base (343572c) to head (645dcf4).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8622      +/-   ##
==========================================
- Coverage   70.17%   70.11%   -0.06%     
==========================================
  Files         536      536              
  Lines       33700    33700              
  Branches     3023     3023              
==========================================
- Hits        23648    23628      -20     
- Misses       9697     9717      +20     
  Partials      355      355              
Flag Coverage Δ
server-test 77.01% <ø> (-0.07%) ⬇️
unittest 45.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants