Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to file-type v19.1.0 #7459

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix: switch to file-type v19.1.0 #7459

merged 1 commit into from
Jul 12, 2024

Conversation

lawvs
Copy link
Member

@lawvs lawvs commented Jul 9, 2024

The official file-type package has replaced the usage of node:buffer with Uint8Array. This change allows it to run safely in the browser now.

Related to sindresorhus/file-type#578

Copy link

graphite-app bot commented Jul 9, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@graphite-app graphite-app bot requested review from EYHN, CatsJuice, forehalo, pengx17 and JimmFly and removed request for CatsJuice July 9, 2024 07:34
Copy link

nx-cloud bot commented Jul 9, 2024

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.11%. Comparing base (5ede985) to head (2f784ae).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7459       +/-   ##
===========================================
- Coverage   57.71%   29.11%   -28.60%     
===========================================
  Files         910      710      -200     
  Lines       40090    16872    -23218     
  Branches     4534     3016     -1518     
===========================================
- Hits        23138     4913    -18225     
+ Misses      16600    11657     -4943     
+ Partials      352      302       -50     
Flag Coverage Δ
server-test ?
unittest 29.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Can you please fix lint issue?

Copy link

graphite-app bot commented Jul 12, 2024

Merge activity

The official `file-type` package has replaced the usage of node:buffer with Uint8Array. This change allows it to run safely in the browser now.

Related to sindresorhus/file-type#578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants