Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up runtime flags and envs #7454

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Jul 9, 2024

No description provided.

Copy link

graphite-app bot commented Jul 9, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

forehalo commented Jul 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 9, 2024

.env.template Show resolved Hide resolved
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.70%. Comparing base (0739e10) to head (2f441d9).

Files Patch % Lines
...pace-slider-bar/user-with-workspace-list/index.tsx 0.00% 2 Missing ⚠️
tools/cli/src/webpack/runtime-config.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7454      +/-   ##
==========================================
+ Coverage   57.68%   57.70%   +0.02%     
==========================================
  Files         913      913              
  Lines       40039    40023      -16     
  Branches     4529     4517      -12     
==========================================
- Hits        23095    23094       -1     
+ Misses      16590    16584       -6     
+ Partials      354      345       -9     
Flag Coverage Δ
server-test 78.54% <ø> (ø)
unittest 28.90% <40.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo force-pushed the 61/runtime-flags branch 3 times, most recently from 20b6d42 to ab61b4c Compare July 9, 2024 08:19
Copy link

graphite-app bot commented Jul 11, 2024

Merge activity

@graphite-app graphite-app bot merged commit 2f441d9 into canary Jul 11, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 61/runtime-flags branch July 11, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants