-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add doc info modal #7409
base: canary
Are you sure you want to change the base?
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 976160b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #7409 +/- ##
==========================================
- Coverage 57.33% 57.29% -0.04%
==========================================
Files 903 913 +10
Lines 39606 39691 +85
Branches 4454 4471 +17
==========================================
+ Hits 22707 22740 +33
- Misses 16547 16599 +52
Partials 352 352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ae8d9f1
to
983904c
Compare
983904c
to
136083e
Compare
702aa17
to
976160b
Compare
packages/frontend/core/src/components/affine/page-properties/info-modal/time-row.tsx
Outdated
Show resolved
Hide resolved
packages/frontend/core/src/components/blocksuite/block-suite-header/menu/index.tsx
Outdated
Show resolved
Hide resolved
const references = useLiveData( | ||
useMemo( | ||
() => LiveData.from(docsSearchService.watchRefsFrom(page.id), null), | ||
[docsSearchService, page.id] | ||
) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is insane @EYHN
976160b
to
9c4e26f
Compare
close AF-1038
close AF-1039
close AF-1040
close AF-1046
A popup window has been added to facilitate viewing of this doc's info in edgeless mode and other modes.
2024-07-05.12.50.26.mov