Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add doc info modal #7409

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from
Open

feat(core): add doc info modal #7409

wants to merge 3 commits into from

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Jul 2, 2024

close AF-1038
close AF-1039
close AF-1040
close AF-1046

A popup window has been added to facilitate viewing of this doc's info in edgeless mode and other modes.

2024-07-05.12.50.26.mov

Copy link

graphite-app bot commented Jul 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Jul 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 2, 2024

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 44.30380% with 44 lines in your changes missing coverage. Please review.

Project coverage is 57.29%. Comparing base (481a226) to head (976160b).

Files Patch % Lines
...s/affine/page-properties/info-modal/info-modal.tsx 11.11% 16 Missing ⚠️
...nts/affine/page-properties/info-modal/time-row.tsx 13.33% 13 Missing ⚠️
...nts/affine/page-properties/info-modal/tags-row.tsx 14.28% 6 Missing ⚠️
...d/core/src/components/page-list/operation-cell.tsx 0.00% 6 Missing ⚠️
...fine/page-properties/info-modal/back-links-row.tsx 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7409      +/-   ##
==========================================
- Coverage   57.33%   57.29%   -0.04%     
==========================================
  Files         903      913      +10     
  Lines       39606    39691      +85     
  Branches     4454     4471      +17     
==========================================
+ Hits        22707    22740      +33     
- Misses      16547    16599      +52     
  Partials      352      352              
Flag Coverage Δ
server-test 78.00% <ø> (ø)
unittest 28.95% <44.30%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly changed the title feat(core): add info modal to doc title bar feat(core): add doc info modal Jul 3, 2024
@JimmFly JimmFly force-pushed the jimmfly/0702/info branch 2 times, most recently from ae8d9f1 to 983904c Compare July 4, 2024 12:08
@github-actions github-actions bot added mod:i18n Related to i18n test Related to test cases labels Jul 4, 2024
@JimmFly JimmFly marked this pull request as ready for review July 5, 2024 04:49
@graphite-app graphite-app bot requested a review from forehalo July 5, 2024 04:49
Comment on lines +48 to +53
const references = useLiveData(
useMemo(
() => LiveData.from(docsSearchService.watchRefsFrom(page.id), null),
[docsSearchService, page.id]
)
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is insane @EYHN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n mod:store test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants