-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add arch key to setup-node cached files #4016
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4016 +/- ##
==========================================
+ Coverage 65.16% 65.18% +0.01%
==========================================
Files 388 388
Lines 11821 11821
Branches 1169 1169
==========================================
+ Hits 7703 7705 +2
+ Misses 3826 3824 -2
Partials 292 292
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a8d4109. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
Deploying with Cloudflare Pages
|
It seems one of the setup-node job stuck at posting cache stage https://github.com/toeverything/AFFiNE/actions/runs/6014482081/job/16314419183?pr=4016 |
Looks like node will store cache regardless the platform's arch. 🤔 |
Sumitted an upstream pr: actions/setup-node#843 |
runner.arch
https://github.com/actions/runner/blob/be65955a9d2503060186d1e8d97a87587051161d/src/Runner.Worker/JobRunner.cs#L149
it seems node-setup always gets stuck for mac. Not sure if this is because we save the same key for both arm64 & x86 for mac.