Skip to content

Commit

Permalink
Allow unesecure node temporarily for manylinux container builds (pant…
Browse files Browse the repository at this point in the history
…sbuild#21172)

Renders github actions and env settings to continue to use node16 inside
the containers that match the glibc (2.17) of manylinux_2014 builder
images. The new default node version for gha requires a much higher
version.

I checked if https://github.com/nodejs/unofficial-builds had node
binaries we could use. It does not.

Based on pantsbuild#21133
  • Loading branch information
tobni committed Jul 22, 2024
1 parent e88caef commit 6678bc0
Show file tree
Hide file tree
Showing 3 changed files with 85 additions and 51 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ jobs:
container:
image: ghcr.io/pantsbuild/wheel_build_aarch64:v3-8384c5cf
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
if: github.repository_owner == 'pantsbuild'
Expand All @@ -20,7 +21,7 @@ jobs:
- ARM64
steps:
- name: Check out code
uses: actions/checkout@v4
uses: actions/checkout@v3
with:
fetch-depth: 10
ref: ${{ needs.release_info.outputs.build-ref }}
Expand Down Expand Up @@ -57,7 +58,7 @@ jobs:
- continue-on-error: true
if: always()
name: Upload pants.log
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: logs-wheels-and-pex-Linux-ARM64
overwrite: 'true'
Expand All @@ -84,6 +85,7 @@ jobs:
container:
image: quay.io/pypa/manylinux2014_x86_64:latest
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
if: github.repository_owner == 'pantsbuild'
Expand All @@ -94,7 +96,7 @@ jobs:
- ubuntu-20.04
steps:
- name: Check out code
uses: actions/checkout@v4
uses: actions/checkout@v3
with:
fetch-depth: 10
ref: ${{ needs.release_info.outputs.build-ref }}
Expand All @@ -121,7 +123,7 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 23.x
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@v4
with:
go-version: 1.19.5
- env:
Expand All @@ -135,7 +137,7 @@ jobs:
- continue-on-error: true
if: always()
name: Upload pants.log
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: logs-wheels-and-pex-Linux-x86_64
overwrite: 'true'
Expand Down Expand Up @@ -167,6 +169,7 @@ jobs:
timeout-minutes: 90
build_wheels_macos10_15_x86_64:
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: false
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
if: github.repository_owner == 'pantsbuild'
Expand Down Expand Up @@ -252,6 +255,7 @@ jobs:
timeout-minutes: 90
build_wheels_macos11_arm64:
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: false
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
if: github.repository_owner == 'pantsbuild'
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ jobs:
container:
image: ghcr.io/pantsbuild/wheel_build_aarch64:v3-8384c5cf
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
MODE: debug
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
Expand All @@ -315,7 +316,7 @@ jobs:
- ARM64
steps:
- name: Check out code
uses: actions/checkout@v4
uses: actions/checkout@v3
with:
fetch-depth: 10
- name: Configure Git
Expand Down Expand Up @@ -350,7 +351,7 @@ jobs:
- continue-on-error: true
if: always()
name: Upload pants.log
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: logs-wheels-and-pex-Linux-ARM64
overwrite: 'true'
Expand All @@ -360,6 +361,7 @@ jobs:
container:
image: quay.io/pypa/manylinux2014_x86_64:latest
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
MODE: debug
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
Expand All @@ -372,7 +374,7 @@ jobs:
- ubuntu-20.04
steps:
- name: Check out code
uses: actions/checkout@v4
uses: actions/checkout@v3
with:
fetch-depth: 10
- name: Configure Git
Expand All @@ -397,7 +399,7 @@ jobs:
repo-token: ${{ secrets.GITHUB_TOKEN }}
version: 23.x
- name: Install Go
uses: actions/setup-go@v5
uses: actions/setup-go@v4
with:
go-version: 1.19.5
- env:
Expand All @@ -411,14 +413,15 @@ jobs:
- continue-on-error: true
if: always()
name: Upload pants.log
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: logs-wheels-and-pex-Linux-x86_64
overwrite: 'true'
path: .pants.d/workdir/*.log
timeout-minutes: 90
build_wheels_macos10_15_x86_64:
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: false
MODE: debug
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
Expand Down Expand Up @@ -487,6 +490,7 @@ jobs:
timeout-minutes: 90
build_wheels_macos11_arm64:
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: false
MODE: debug
PANTS_REMOTE_CACHE_READ: 'false'
PANTS_REMOTE_CACHE_WRITE: 'false'
Expand Down
Loading

0 comments on commit 6678bc0

Please sign in to comment.