Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: use triggers and change table for reactivity on native #4279

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

patosullivan
Copy link
Member

Fixes reactivity issue we were seeing on both platforms by:

  1. fixing an issue with a field name in triggers
  2. using the triggers and change table/polling method on native to get around the issues we found with op-sqlite's updateHook.

This also creates a new BaseDb class where shared code for both platforms can live.

I tested this out in the sim on native and watched the CPU usage in xcode, didn't notice any difference over the current baseline (which I found to be pretty bad on initial channel load, fwiw).

fixes tlon-3317

Copy link

linear bot commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant