Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikiman: add page #14922

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

wikiman: add page #14922

wants to merge 3 commits into from

Conversation

jpnadas
Copy link

@jpnadas jpnadas commented Nov 20, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Nov 20, 2024
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/wikiman.md:
Error: Parse error on line 17:
...]ources:`wikiman``-s {{{source1}},{{so
---------------------^
Expecting 'NEWLINE', 'TEXT', 'DASH', 'BACKTICK', got 'COMMAND_TEXT'
pages/common/wikiman.md:5: TLDR011 Page never contains more than a single empty line
pages/common/wikiman.md:16: TLDR014 Page should contain no trailing whitespace

Please fix the error(s) and push again.

pages/common/wikiman.md Outdated Show resolved Hide resolved
@spageektti
Copy link
Member

Hi. Thank you so much for your contribution

pages/common/wikiman.md Show resolved Hide resolved
jpnadas and others added 3 commits November 22, 2024 10:56
co-author: spageektti

Co-authored-by: Wiktor Perskawiec <[email protected]>
@jpnadas
Copy link
Author

jpnadas commented Nov 22, 2024

Hi. Thank you so much for your contribution

@spageektti if it looks good for you, could you approve it?

Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after this suggestion

Comment on lines +15 to +17
- Search for a topic on two specific [s]ources:

`wikiman -s {{source1}},{{source2}} {{search_term}}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be more than two?

Suggested change
- Search for a topic on two specific [s]ources:
`wikiman -s {{source1}},{{source2}} {{search_term}}`
- Search for a topic on two or more specific [s]ources:
`wikiman -s {{source1,source2,...}} {{search_term}}`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants