-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2599: Updated the demo content and configurations as requested. #3564
Conversation
We could add an
|
@FarzadHayat Yeah sounds like a good idea, however the above code snippet is missing the |
Yes I intentionally removed that. Since the snippet does not include our public key, it doesn't need our custom CDN base URL. The default value for the option will work better for someone trying to copy paste this code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Demo works fine with updated configs and content.
Ticket: DOC-2599
Site: Staging branch
Changes:
Pre-checks:
feature/<version>/
,hotfix/<version>/
,staging/<version>/
, orrelease/<version>/
.Review: