Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2599: Updated the demo content and configurations as requested. #3564

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

abhinavgandham
Copy link

@abhinavgandham abhinavgandham commented Dec 12, 2024

Ticket: DOC-2599

Site: Staging branch

Changes:

  • Updated the content and configurations for the Uploadcare Image Optimizer demo.

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.

Review:

  • Documentation Team Lead has reviewed

@FarzadHayat
Copy link
Contributor

We could add an example.js to hide uploadcare_public_key and make it slightly more difficult for people to abuse our public key. @abhinavgandham @ShiridiGandham

tinymce.init({
  selector: "textarea",
  plugins: [ "uploadcare", "code", "link", "preview", "lists" ],
  uploadcare_public_key: '<your-public-key>',
  uploadcare_store_type: 'temporary',
  a11y_advanced_options: true,	
  toolbar: "undo redo | styles | bold italic underline | forecolor | bullist numlist| link uploadcare | code preview",
  height: 700,	
  content_style: `
    body { max-width: 920px; margin: 1.5rem auto; padding: 0 2vw; }
    h1 { font-size: 1.5em; }
        h2 { font-size: 1.17em; }
    h1, h2, h3, h4, h5, h6 { font-weight: 500; margin: 0 0 0.75rem; }
    p + h1, p + h2, p + h3, p + h4, p + h5, p + h6 { margin-top: 2rem; }
    p { line-height: 1.6; margin: 0; } 
    p + p { margin-top: 1rem; }
    a { color: #2b70e3; }
    blockquote { color: #4e5c73; font-weight: 200; font-size: 1.3rem; margin: 1rem 2rem; padding: 0 0 0 1rem; border-left: 2px solid #2b70e3 !important; }
    figcaption {font-size: 0.875em;}
  `
});

@abhinavgandham
Copy link
Author

@FarzadHayat Yeah sounds like a good idea, however the above code snippet is missing the uploadcare_cdn_base_url, is this intentional?

@FarzadHayat
Copy link
Contributor

@FarzadHayat Yeah sounds like a good idea, however the above code snippet is missing the uploadcare_cdn_base_url, is this intentional?

Yes I intentionally removed that. Since the snippet does not include our public key, it doesn't need our custom CDN base URL. The default value for the option will work better for someone trying to copy paste this code.

@FarzadHayat FarzadHayat self-requested a review December 13, 2024 06:37
Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo works fine with updated configs and content.

@ShiridiGandham ShiridiGandham merged commit 0c7c2a8 into tinymce/7 Dec 13, 2024
5 checks passed
@ShiridiGandham ShiridiGandham deleted the hotfix/7/DOC-2599 branch December 13, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants