Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-2502: Update code example for running tinymce in shadow dom v6/docs #3430

Merged
merged 1 commit into from
Aug 16, 2024
Merged

DOC-2502: Update code example for running tinymce in shadow dom v6/docs #3430

merged 1 commit into from
Aug 16, 2024

Conversation

kemister85
Copy link
Contributor

@kemister85 kemister85 commented Aug 16, 2024 •
edited by FarzadHayat
Loading

Ticket: DOC-2502

Site: Staging branch

Changes:

  • port changes made in v7-docs in PR3429

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.
  • Verified on 6-stable that the config works as expected.

Review:

  • Documentation Team Lead has reviewed

@kemister85 kemister85 requested a review from a team as a code owner August 16, 2024 05:31
ShiridiGandham
ShiridiGandham approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FarzadHayat FarzadHayat merged commit 0707a92 into tinymce/6 Aug 16, 2024
5 checks passed
@FarzadHayat FarzadHayat deleted the hotfix/6/DOC-2502_v6 branch August 16, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiridiGandham ShiridiGandham ShiridiGandham approved these changes

@FarzadHayat FarzadHayat FarzadHayat approved these changes

@EkimChau EkimChau Awaiting requested review from EkimChau EkimChau is a code owner automatically assigned from tinymce/documentation-team

@katepotemina katepotemina Awaiting requested review from katepotemina katepotemina is a code owner automatically assigned from tinymce/documentation-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kemister85 @FarzadHayat @ShiridiGandham