Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2367 restore creating-a-skin.adoc and only remove link to the Skin Tool #3214

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

FarzadHayat
Copy link
Contributor

@FarzadHayat FarzadHayat commented Apr 9, 2024

Ticket: DOC-2367

Site: DOC-2367 site

There was an error made in the previous hotfix. The intended change is to just remove the link to the Skin Tool which is only available in TinyMCE 5. Users can still create custom skins in later versions.

Changes:

  • DOC-2367 restore creating-a-skin.adoc and only remove link to the Skin Tool

Pre-checks:

  • Branch prefixed with feature/6/ or hotfix/6/
  • modules/ROOT/nav.adoc has been updated (if applicable)
  • Files has been included where required (if applicable)
  • [-] Files removed have been deleted, not just excluded from the build (if applicable)
  • [-] Files added for New product features, and included a release note entry.

Review:

  • Documentation Team Lead has reviewed

@FarzadHayat FarzadHayat self-assigned this Apr 9, 2024
@FarzadHayat FarzadHayat requested a review from a team as a code owner April 9, 2024 07:26
@FarzadHayat FarzadHayat requested review from Afraithe, EkimChau, kemister85, ShiridiGandham and lostkeys and removed request for Afraithe and EkimChau April 9, 2024 07:26
Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FarzadHayat FarzadHayat requested review from a team, Afraithe, EkimChau, TheSpyder, ltrouton, MitchC1999 and shanmen-tiny and removed request for a team April 10, 2024 01:05
Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FarzadHayat FarzadHayat merged commit b3fa0e5 into release/docs-6 Apr 10, 2024
5 checks passed
@FarzadHayat FarzadHayat deleted the hotfix/6/DOC-2367_2 branch April 10, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants