-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-2174: added documentation for Mentions plugin's getUsers
API deprecation to 6.0-release-notes-premium-changes.adoc
and migration-from-5x.adoc
#3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 6 migration guide
FarzadHayat
changed the title
DOC-2174: added documentation for Mentions plugin's getUsers API deprecation
DOC-2174: added documentation for Mentions plugin's Feb 8, 2024
getUsers
API deprecation to 6.0-release-notes-premium-changes.adoc
and migration-from-5x.adoc
Just thought I would put up a first draft, open to suggestions! Some questions regarding the demo for reviewers:
|
FarzadHayat
commented
Feb 8, 2024
FarzadHayat
requested review from
Afraithe,
ShiridiGandham and
lorenzo-pomili
February 9, 2024 01:04
kemister85
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FarzadHayat Well done, i think this is a good improvement as discussed.
MitchC1999
approved these changes
Feb 12, 2024
modules/ROOT/examples/live-demos/getusers-api-alternative/index.html
Outdated
Show resolved
Hide resolved
modules/ROOT/examples/live-demos/getusers-api-alternative/index.js
Outdated
Show resolved
Hide resolved
modules/ROOT/examples/live-demos/getusers-api-alternative/index.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Mitchell Crompton <[email protected]>
FarzadHayat
commented
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-2174, getUsers API deprecation in v6 not documented.
Changes:
Pre-checks:
feature/6/
orhotfix/6/
Review: