hd44780: configure and write fixes #647
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Write only the high-part of the byte when configuring in 4-bit mode similar to the LiquidCrystal library around [here](https://github.com/arduino-libraries/LiquidCrystal/blob/1.0.7/src/LiquidCrystal.cpp#L116) - Pulse enable after writing data similar to the LiquidCrystal library: [4-bits here](https://github.com/arduino-libraries/LiquidCrystal/blob/1.0.7/src/LiquidCrystal.cpp#L312), [8-bits here](https://github.com/arduino-libraries/LiquidCrystal/blob/1.0.7/src/LiquidCrystal.cpp#L320) Addresses issue [tinygo-org#646](tinygo-org#646).
sorf
force-pushed
the
issue-646-hd44780
branch
from
2d41cc1
to
67f5ced
Compare
|
I tested this as requested and was still getting panic with my setup and this particular 16X1 VFD. I posted my workaround in #646 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write only the high-part of the byte when configuring in 4-bit mode similar to the LiquidCrystal library around
here
Pulse enable after writing data similar to the LiquidCrystal library:
4-bits here, 8-bits here
Addresses issue #646.