-
Notifications
You must be signed in to change notification settings - Fork 102
Add setter and getter for normal and selected dot size #45
Open
melikaafrakhteh
wants to merge
1
commit into
tinkoff-mobile-tech:master
Choose a base branch
from
melikaafrakhteh:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,8 +31,8 @@ public class ScrollingPagerIndicator extends View { | |
private int infiniteDotCount; | ||
|
||
private final int dotMinimumSize; | ||
private final int dotNormalSize; | ||
private final int dotSelectedSize; | ||
private int dotNormalSize; | ||
private int dotSelectedSize; | ||
private final int spaceBetweenDotCenters; | ||
private int visibleDotCount; | ||
private int visibleDotThreshold; | ||
|
@@ -131,6 +131,43 @@ public void setDotColor(@ColorInt int color) { | |
invalidate(); | ||
} | ||
|
||
/** | ||
* @return the dot size | ||
*/ | ||
|
||
public int getDotSize() { | ||
return dotNormalSize; | ||
} | ||
|
||
/** | ||
* Sets dot size | ||
* | ||
* @param size dot color | ||
*/ | ||
public void setDotSize(int size) { | ||
dotNormalSize = size; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems like you need also change dotMinimumSize, like in constructor. |
||
requestLayout(); | ||
} | ||
|
||
/** | ||
* @return the selected dot size | ||
*/ | ||
|
||
public int getSelectedDotSize() { | ||
return dotSelectedSize; | ||
} | ||
|
||
/** | ||
* Sets selected dot size | ||
* | ||
* @param size selected dot color | ||
*/ | ||
|
||
public void setSelectedDotSize(int size) { | ||
dotSelectedSize = size; | ||
requestLayout(); | ||
} | ||
|
||
/** | ||
* @return the selected dot color | ||
*/ | ||
|
@@ -358,8 +395,7 @@ public void onPageScrolled(int page, float offset) { | |
} else if (itemCount > 1) { | ||
scaleDotByOffset(0, 1 - offset); | ||
} | ||
} | ||
else { // Vertical orientation | ||
} else { // Vertical orientation | ||
scaleDotByOffset(page - 1, offset); | ||
scaleDotByOffset(page, 1 - offset); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for this feature? Do you need dynamically change dot sizes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, because I cannot use xml and I have to change the size of dots programmatically in code. The default size is not ok for my slider.