Develop client/session separation #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use containers, Go 1.4, and update cover location
run on all pull requests and any commits directly to master or develop. don't send emails.
Revise Travis CI config
and lint fixes
document exported identifiers
used by feedback service.
don't break API for now
at least for now, may bring this functionality back ref #19
and session error is just the error from Apple
| return s.Err.Error() | ||
| } | ||
|
|
||
| func (b *buffer) FindFailedNotification(e Error) NotificationResult { |
There was a problem hiding this comment.
This isn't being used yet.
|
In light of #57 (HTTP/2), maybe we should pull back this change and just make a few minor changes to fix broken tests for now. |
|
I'd support that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Issue #31. Continuation of PR #33.