Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update facet_wrap (adjsut the strip position for each panel when strip.placement is "outside") #5934

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

junjunlab
Copy link

  1. Making sure the strip.switch.pad.wrap works when strip.placement=outside and strip.position="top".
  2. Giving same gap between the strip and panel when strip.position is "left"/"right" or when nrow>2.

@teunbrand
Copy link
Collaborator

Hi, thanks for putting together a PR!
If I read the code correctly, this change applies the padding regardless of whether an axis is placed between the panel and the strip, right?
If so, that breaks with what is documented for the strip.switch.pad.* arguments.
Would you mind opening an issue first describing the problem you are interested in solving?
This way, we may be able to discuss and better guide a contribution.

@junjunlab
Copy link
Author

Sure, I will open an issue now. Thanks for your replying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants