Guard against old discrete scales with identity palettes #5933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasp85
reviewed
Jul 7, 2024
R/scale-discrete-.R
Outdated
Comment on lines
143
to
146
| # Guard against old use of having identity palettes | ||
| if (identical(.subset2(self, "palette"), identity)) { | ||
| self$palette <- seq_len | ||
| } |
There was a problem hiding this comment.
Could we fix this during construction? instead of checking at every map call?
This reverts commit 8031a33.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an amendement to #5770.
Briefly, we introduced the
paletteargument, but revdep check show that some people contstruct their discrete position scales usingdiscrete_scale(..., palette = identity). The identity palette is problematic as it doesn't return the expected values. This PR replaces identity palettes withseq_lento keep consistent behaviour with older scales.