MdeModulePkg/PciBusDxe: Remove assert when PCI enum is disabled #5862
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgao4
approved these changes
Jul 3, 2024
niruiyu
reviewed
Jul 5, 2024
When setting PcdPciDisableBusEnumeration to TRUE, an assert is hit in StartPciDevices() due to the root bridge not existing. This is expected when skipping enumeration so change the assert to only trigger if enumeration is not disabled. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
mdemodulepkg_ignore_pci_assert_when_enum_disabled
branch
from
3fdcbb5
to
bf45e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting PcdPciDisableBusEnumeration to TRUE, an assert is hit in StartPciDevices() due to the root bridge not existing. This is expected when skipping enumeration so change the assert to only trigger if enumeration is not disabled.
How This Was Tested
Integration Instructions