SctPkg: Drop ArmCompilerIntrinsicsLib #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edk2 PR tianocore/edk2#6048 moves ArmCompilerIntrinsicsLib to MdePkg and into MdeLibs.dsc.inc. This patch drops all of the references to the ArmPkg location as these *_SCT.dsc are now getting it from MdeLibs.dsc.inc. This is done in one shot as it is a breaking change and has no functional impact. Signed-off-by: Nhi Pham <[email protected]>
|
Hi @edhay @sunnywang-arm |
|
Looks good to me as well. For merging the change, we need to get maintainers (https://github.com/tianocore/edk2-test/blob/master/Maintainers.txt) to work on it. |
|
By the way, as I know, Edhaya is working on CI/CD for pull requests, so we may need to wait for CI/CD to get ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edk2 PR tianocore/edk2#6048 moves
ArmCompilerIntrinsicsLib to MdePkg and into MdeLibs.dsc.inc.
This patch drops all of the references to the ArmPkg location as these *_SCT.dsc are now getting it from MdeLibs.dsc.inc. This is done in one shot as it is a breaking change and has no functional impact.