Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMMT GuidTool Auto Select Config file #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YuweiChen1110
Copy link
Contributor

Currently, Python FMMT tool does not support automatically select FMMTConf.ini file which saves GuidTool settings. This patch support this features.

Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch support this features.

Signed-off-by: Yuwei Chen <[email protected]>
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d9b898) 4.27% compared to head (1c2d7d8) 4.27%.
Report is 1 commits behind head on master.

❗ Current head 1c2d7d8 differs from pull request most recent head 4a0dd32. Consider uploading reports for the commit 4a0dd32 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #100   +/-   ##
======================================
  Coverage    4.27%   4.27%           
======================================
  Files         182     182           
  Lines       81605   81605           
======================================
  Hits         3490    3490           
  Misses      78115   78115           
Flag Coverage Δ
Linux 4.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch support this features.

Cc: Rebecca Cran <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Bob Feng <[email protected]>
Signed-off-by: Yuwei Chen <[email protected]>
Copy link
Member

@bcran bcran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be a single commit, not two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants