Skip to content

Commit

Permalink
Add google/sanitizers#1816 to FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
thurstond committed Nov 13, 2024
1 parent 5789cca commit 7558d41
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ void SetSigProcMask(__sanitizer_sigset_t *set, __sanitizer_sigset_t *oldset) {
// Equivalently: newset[signum] = newset[signum] & oldset[signum]
static void KeepUnblocked(__sanitizer_sigset_t &newset,
__sanitizer_sigset_t &oldset, int signum) {
// FIXME: this causes mysterious failures on Android
// FIXME: https://github.com/google/sanitizers/issues/1816
if (SANITIZER_ANDROID || !internal_sigismember(&oldset, signum))
internal_sigdelset(&newset, signum);
}
Expand All @@ -179,7 +179,7 @@ static void KeepUnblocked(__sanitizer_sigset_t &newset,
void BlockSignals(__sanitizer_sigset_t *oldset) {
__sanitizer_sigset_t currentset;
# if !SANITIZER_ANDROID
// FIXME: SetSigProcMask cause mysterious failures on Android
// FIXME: https://github.com/google/sanitizers/issues/1816
SetSigProcMask(NULL, &currentset);
# endif

Expand All @@ -201,7 +201,7 @@ void BlockSignals(__sanitizer_sigset_t *oldset) {
# if SANITIZER_LINUX && !SANITIZER_ANDROID
// Don't block synchronous signals
// but also don't unblock signals that the user had deliberately blocked.
// FIXME: this causes mysterious failures on Android
// FIXME: https://github.com/google/sanitizers/issues/1816
KeepUnblocked(newset, currentset, SIGSEGV);
KeepUnblocked(newset, currentset, SIGBUS);
KeepUnblocked(newset, currentset, SIGILL);
Expand Down

0 comments on commit 7558d41

Please sign in to comment.