Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply sensai-utils, removing copied code #1199

Merged
merged 3 commits into from
Aug 10, 2024
Merged

Apply sensai-utils, removing copied code #1199

merged 3 commits into from
Aug 10, 2024

Conversation

opcode81
Copy link
Collaborator

@opcode81 opcode81 commented Aug 10, 2024

Remove the code copied from sensAI, using the new library sensAI-utils instead (which does not add any additional dependencies to Tianshou)

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes and have listed relevant changes in CHANGELOG.md
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

@opcode81 opcode81 added the refactoring No change to functionality label Aug 10, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.50%. Comparing base (bd74273) to head (fdfefb8).
Report is 1 commits behind head on master.

Files Patch % Lines
tianshou/evaluation/rliable_evaluation_hl.py 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
+ Coverage   84.78%   85.50%   +0.71%     
==========================================
  Files         104      102       -2     
  Lines        8983     8649     -334     
==========================================
- Hits         7616     7395     -221     
+ Misses       1367     1254     -113     
Flag Coverage Δ
unittests 85.50% <93.10%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MischaPanch MischaPanch marked this pull request as ready for review August 10, 2024 14:50
@MischaPanch MischaPanch merged commit f5d2ae6 into master Aug 10, 2024
4 checks passed
@MischaPanch MischaPanch deleted the sensai-utils branch August 10, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring No change to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants