-
-
Notifications
You must be signed in to change notification settings - Fork 57
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Heroku now offers their own `redis:cli` subcommand, making this unnecessary. This change will require a major release as we're removing the feature entirely.
- Loading branch information
1 parent
b94557a
commit 81893f7
Showing
3 changed files
with
0 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -224,22 +224,6 @@ | |
expect(Kernel).to have_received(:exec).with(*open) | ||
end | ||
|
||
it "opens a Redis session connected to the environment's Redis service" do | ||
allow(Open3).to receive(:capture3).and_return(open3_redis_url_fetch_result) | ||
|
||
Parity::Environment.new("production", ["redis_cli"]).run | ||
|
||
expect(Kernel).to have_received(:system).with( | ||
"redis-cli", | ||
"-u", | ||
open3_redis_url_fetch_result[0].strip, | ||
) | ||
expect(Open3). | ||
to have_received(:capture3). | ||
with(fetch_redis_url("REDIS_URL")). | ||
once | ||
end | ||
|
||
it "returns true if deploy was successful without migrations" do | ||
result = Parity::Environment.new("production", ["deploy"]).run | ||
|
||
|
@@ -327,18 +311,6 @@ def open | |
["heroku", "open", "--remote", "production"] | ||
end | ||
|
||
def fetch_redis_url(env_variable) | ||
"heroku config:get #{env_variable} --remote production" | ||
end | ||
|
||
def open3_redis_url_fetch_result | ||
[ | ||
"redis://redistogo:[email protected]:90210/\n", | ||
"", | ||
"" | ||
] | ||
end | ||
|
||
def psql_count | ||
[ | ||
"heroku", "pg:psql", | ||
|