This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Removed mimemagic and falling back to file due to incompatible licence #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theianjones
reviewed
Apr 8, 2021
| @@ -1,3 +1,3 @@ | |||
| module Paperclip | |||
| VERSION = "4.3.7".freeze unless defined? Paperclip::VERSION | |||
| VERSION = "4.3.6".freeze unless defined? Paperclip::VERSION | |||
There was a problem hiding this comment.
isnt the next version 4.3.8?
Suggested change
| VERSION = "4.3.6".freeze unless defined? Paperclip::VERSION | |
| VERSION = "4.3.8".freeze unless defined? Paperclip::VERSION |
There was a problem hiding this comment.
Hah! It turns out I can't increment numbers- must have missed that day in school.
I no longer have access to the original repo I made this PR from, so please feel free to close this PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those who like to live on the bleeding edge, I've updated a 5~ year old version with the mimemagic fix 😎