This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Update url_generator.rb #2676
Open
Update url_generator.rb #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undefined method `escape' for URI:Module with Ruby 3.0.0 This method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.
|
Looks good to me. Would you submit it to https://github.com/kreeti/kt-paperclip |
Layout/SpaceBeforeBlockBraces: Space missing to the left of {.
Layout/SpaceInsideBlockBraces: Space between { and | missing.
Metrics/LineLength: Line is too long. [95/80]
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -65,7 +65,9 @@ def escape_url(url) | |||
| if url.respond_to?(:escape) | |||
| url.escape | |||
| else | |||
| URI.escape(url).gsub(escape_regex){|m| "%#{m.ord.to_s(16).upcase}" } | |||
| URI.encode_www_form_component(url).gsub(escape_regex) { | |||
There was a problem hiding this comment.
Style/BlockDelimiters: Avoid using {...} for multi-line blocks.
Layout/TrailingWhitespace: Trailing whitespace detected.
|
is kt-paperclip a direct replacement? is paperclip completely unsupported now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefined method `escape' for URI:Module with Ruby 3.0.0
This method is obsolete and should not be used. Instead, use
CGI.escape, URI.encode_www_form or URI.encode_www_form_component
depending on your specific use case.