Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asdf-nodejs plugin removed import-release-team-keyring script #600

Closed
jbeard6 opened this issue Jan 12, 2022 · 3 comments · Fixed by #608
Closed

asdf-nodejs plugin removed import-release-team-keyring script #600

jbeard6 opened this issue Jan 12, 2022 · 3 comments · Fixed by #608

Comments

@jbeard6
Copy link

jbeard6 commented Jan 12, 2022

The mac script attempts to execute the nodejs release team keyring using a script provided by the asdf-nodejs plugin. This script was removed in #272, causing the mac script to fail prematurely.
@jbeard6
Copy link
Author

jbeard6 commented Jan 12, 2022

It's possible that removing this call will negate some of the concern around #531.

@AndyObtiva
Copy link

I just got this error too:

Installing latest Node ...
bash: /Users/user/.asdf/plugins/nodejs/bin/import-release-team-keyring: No such file or directory
failed

@cpytel cpytel mentioned this issue Mar 30, 2022
Merged
cpytel added a commit that referenced this issue Mar 31, 2022
@cpytel
Use brew asdk, changes for latest node (#608)
a37310c 
Closes #563 
Closes #587
Closes #600

This makes the following changes:

* Installs asdf via Homebrew, thanks @jdbann in #592 and @gssbzn in #597
* The latest version of the asdf nodejs plugin takes care of the keyring stuff itself.
@cpytel
Copy link
Member

cpytel commented Mar 31, 2022

Thanks for your contributions, I've merged this in #608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use brew asdf, changes for latest asdf nodejs thoughtbot/laptop
3 participants
@cpytel @AndyObtiva @jbeard6