This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Migrate to [email protected] #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `addon-background|controls|knobs` in favour of using `addon-essentials|interactions|links|node-logger` (as same as `npx sb init` is adding addons) - see https://storybook.js.org/docs/react/get-started/install - Comment usage of knobs in stories (will be fixed with another PR - storybook needs to run before - see https://github.com/thorchain/asgardex-electron/issues/2248)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
storybookis still broken due lack ofReact 18support in latest[email protected].Details
[email protected]yarn.lock(similar to [Bug] ENAMETOOLONG on "preset-create-react-app@4" package installation storybookjs/presets#246)babel-loadertoresolutionsas a workaround as long as we use CRA 4 (cracodoes not support CRA5 yet - see **** Update to CRA 5 **** dilanx/craco#378). Workaround based on babel-loader conflicts with create-react-app version storybookjs/storybook#5183 (comment)knobsin stories (will be fixed with another PR -storybook needs to run before - see #2248)