Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly handle files with whitespace #248

Merged
merged 1 commit into from
Oct 19, 2024
Merged

fix: Properly handle files with whitespace #248

merged 1 commit into from
Oct 19, 2024

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Oct 12, 2023 •
edited
Loading

A bisect confirmed that this was introduced from commit 994839f.

Closes #89
Closes #127
Closes #158

PeterDaveHello
PeterDaveHello approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of the original reason to use the method, maybe it's historical issue, but it look like we really to fix it right now.

@PeterDaveHello PeterDaveHello merged commit f8a2cf5 into thlorenz:master Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterDaveHello PeterDaveHello PeterDaveHello approved these changes

@thlorenz thlorenz Awaiting requested review from thlorenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hyperupcall @PeterDaveHello