Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve commands on windows to return stdout and stderr #108

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

brianheineman
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the fix Bug fix label Jul 17, 2024
Copy link

github-actions bot commented Jul 17, 2024

🐰Bencher

ReportWed, July 17, 2024 at 02:41:08 UTC
Projecttheseus-rs/postgresql-embedded
Branchimprove-windows-commands
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
extract➖ (view plot)155,310.00
lifecycle➖ (view plot)1,212,800,000.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Project coverage is 99.46%. Comparing base (282e75f) to head (14863d5).

Files Patch % Lines
postgresql_commands/src/traits.rs 77.41% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   99.58%   99.46%   -0.12%     
==========================================
  Files          78       78              
  Lines        8575     8586      +11     
==========================================
+ Hits         8539     8540       +1     
- Misses         36       46      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit a3f0c4b into main Jul 17, 2024
11 of 13 checks passed
@brianheineman brianheineman deleted the improve-windows-commands branch July 17, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant