Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Interface #3

wants to merge 8 commits into from

Conversation

ryanburnette
Copy link
Collaborator

No description provided.

@ryanburnette ryanburnette force-pushed the interface branch 2 times, most recently from def37a5 to ae4169d Compare October 24, 2020 01:27
@ryanburnette
Copy link
Collaborator Author

@coolaj86 I think that by default, there should be no interface.

I'd like to make the serving of the ./public/ dir a condition of whether or not that directory exists.

@ryanburnette
Copy link
Collaborator Author

Okay I learned a bit more since the last comment. Right now, it builds the HTML in based on what's in the public dir at build time.

Let's talk about how this should work.

It might be best for it to serve what's actually in the public directory, not compiling anything into the binary at all.

Default functionality: no interface

If you want the default interface: run gitdeploy init interface or something like that and it copies it into ./public/ and serves it.

Or you just put whatever you want in ./public/ and it serves it.

Thoughts?

@coolaj86
Copy link
Contributor

coolaj86 commented Oct 24, 2020

Mostly just that you might read the readme or --help before suggesting things that already exist.

@ryanburnette
Copy link
Collaborator Author

What did I suggest that already exists?

@coolaj86
Copy link
Contributor

 --serve-path string
    	path to serve, falls back to built-in web app

@coolaj86
Copy link
Contributor

I'd actually like the default interface to be documentation / debug console.

@ryanburnette
Copy link
Collaborator Author

ryanburnette commented Oct 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants